From 7785dbe8f8012324b502878b68e650fa8929ad8a Mon Sep 17 00:00:00 2001 From: Gulshan Yadav Date: Mon, 26 Jan 2026 23:59:27 +0530 Subject: [PATCH] fix: remove unused imports and suppress warnings in various modules --- apps/synord/tests/byzantine_fault_tests.rs | 36 ++++--------------- crates/synor-compute/src/scheduler/mod.rs | 2 +- .../synor-economics/src/pricing/discounts.rs | 2 +- crates/synor-ibc/src/handler.rs | 1 - crates/synor-storage/src/car.rs | 2 +- crates/synor-verifier/src/prover.rs | 1 - sdk/flutter/analysis_options.yaml | 1 + sdk/flutter/example/example.dart | 2 ++ 8 files changed, 13 insertions(+), 34 deletions(-) diff --git a/apps/synord/tests/byzantine_fault_tests.rs b/apps/synord/tests/byzantine_fault_tests.rs index 7c4eed7..1964f9a 100644 --- a/apps/synord/tests/byzantine_fault_tests.rs +++ b/apps/synord/tests/byzantine_fault_tests.rs @@ -11,15 +11,11 @@ //! - DAG reorg handling //! - Parallel blocks (GHOSTDAG) resolution -use std::collections::{HashMap, HashSet}; -use std::sync::atomic::{AtomicU64, Ordering}; use std::sync::Arc; use std::time::Duration; -use parking_lot::RwLock; use tempfile::TempDir; -use tokio::sync::{broadcast, mpsc, Barrier}; -use tokio::time::{sleep, timeout}; +use tokio::time::sleep; use tracing::info; use synord::config::NodeConfig; @@ -29,15 +25,9 @@ use synord::node::{NodeState, SynorNode}; // Test Configuration Constants // ============================================================================= -/// Default test timeout for async operations. -const TEST_TIMEOUT: Duration = Duration::from_secs(60); - /// Time to wait for network operations to settle. const NETWORK_SETTLE_TIME: Duration = Duration::from_millis(500); -/// Byzantine fault tolerance threshold (f nodes can be faulty in 3f+1 total nodes). -const BFT_THRESHOLD: usize = 3; - // ============================================================================= // Test Helpers // ============================================================================= @@ -58,23 +48,11 @@ fn create_node_config(temp_dir: &TempDir, node_index: u16, seeds: Vec) - config } -/// Creates a mining-enabled node configuration. -fn create_miner_config( - temp_dir: &TempDir, - node_index: u16, - seeds: Vec, - coinbase_addr: &str, -) -> NodeConfig { - let mut config = create_node_config(temp_dir, node_index, seeds); - config.mining.enabled = true; - config.mining.coinbase_address = Some(coinbase_addr.to_string()); - config.mining.threads = 1; - config -} - /// Test network for Byzantine fault scenarios. struct TestNetwork { nodes: Vec>, + /// Temp directories kept to ensure they are not dropped during tests + #[allow(dead_code)] temp_dirs: Vec, } @@ -123,7 +101,7 @@ impl TestNetwork { let mut nodes = Vec::new(); let mut node_index = 0u16; - for (group_idx, &group_size) in group_sizes.iter().enumerate() { + for (_group_idx, &group_size) in group_sizes.iter().enumerate() { // First node of each group is the seed for that group let group_seed_port = 20000 + (std::process::id() % 500) as u16 * 10 + node_index * 3; @@ -173,7 +151,7 @@ impl TestNetwork { let to_config = self.nodes[to].config(); let to_addr = &to_config.p2p.listen_addr; let from_network = self.nodes[from].network(); - from_network.connect_peer(to_addr).await; + let _ = from_network.connect_peer(to_addr).await; Ok(()) } @@ -441,7 +419,7 @@ mod double_spend_tests { // For now, verify mempool API is working // and handles empty/invalid data gracefully - let invalid_tx = vec![0u8; 50]; // Invalid transaction bytes + let _invalid_tx = vec![0u8; 50]; // Invalid transaction bytes (for future use) // Submitting invalid tx should fail gracefully // Mempool should maintain integrity @@ -1493,7 +1471,7 @@ mod timing_attack_tests { let tips: Vec<[u8; 32]> = consensus.tips().await; for tip in tips.iter().take(1) { - if let Some(info) = consensus.get_block_info(tip).await { + if let Some(_info) = consensus.get_block_info(tip).await { info!( block = hex::encode(&tip[..8]), "Block with validated timestamp" diff --git a/crates/synor-compute/src/scheduler/mod.rs b/crates/synor-compute/src/scheduler/mod.rs index aa7c15d..9ade413 100644 --- a/crates/synor-compute/src/scheduler/mod.rs +++ b/crates/synor-compute/src/scheduler/mod.rs @@ -515,7 +515,7 @@ pub enum TaskExecutionResult { #[cfg(test)] mod tests { use super::*; - use crate::processor::{Operation, Precision}; + use crate::processor::Operation; use crate::task::{TaskPriority, TaskStatus}; fn create_test_task(id: u64, op: Operation, deps: Vec) -> Task { diff --git a/crates/synor-economics/src/pricing/discounts.rs b/crates/synor-economics/src/pricing/discounts.rs index 5acc03e..bdf2b84 100644 --- a/crates/synor-economics/src/pricing/discounts.rs +++ b/crates/synor-economics/src/pricing/discounts.rs @@ -370,7 +370,7 @@ mod tests { #[test] fn test_discount_expiry() { - let mut discount = Discount::percentage("EXPIRED", "Expired", dec!(10)) + let discount = Discount::percentage("EXPIRED", "Expired", dec!(10)) .with_expiry(Utc::now() - chrono::Duration::days(1)); assert!(!discount.is_valid()); diff --git a/crates/synor-ibc/src/handler.rs b/crates/synor-ibc/src/handler.rs index 5ae62c4..ba17b8b 100644 --- a/crates/synor-ibc/src/handler.rs +++ b/crates/synor-ibc/src/handler.rs @@ -606,7 +606,6 @@ impl Default for IbcHandler { #[cfg(test)] mod tests { use super::*; - use crate::client::TrustLevel; use crate::types::ChainId; fn setup_handler() -> IbcHandler { diff --git a/crates/synor-storage/src/car.rs b/crates/synor-storage/src/car.rs index 5fe4ec6..55eda03 100644 --- a/crates/synor-storage/src/car.rs +++ b/crates/synor-storage/src/car.rs @@ -471,7 +471,7 @@ mod tests { let mut builder = CarBuilder::new(root.clone()); let cid1 = builder.add_content(b"block 1".to_vec()); - let cid2 = builder.add_content(b"block 2".to_vec()); + let _cid2 = builder.add_content(b"block 2".to_vec()); // Adding same content again should not create new block let cid1_again = builder.add_content(b"block 1".to_vec()); diff --git a/crates/synor-verifier/src/prover.rs b/crates/synor-verifier/src/prover.rs index e4be3fc..7d831aa 100644 --- a/crates/synor-verifier/src/prover.rs +++ b/crates/synor-verifier/src/prover.rs @@ -263,7 +263,6 @@ impl Prover { #[cfg(test)] mod tests { use super::*; - use crate::ast::{BinaryOperator, Literal}; #[test] fn test_prover_config_default() { diff --git a/sdk/flutter/analysis_options.yaml b/sdk/flutter/analysis_options.yaml index 2d9eedd..b577624 100644 --- a/sdk/flutter/analysis_options.yaml +++ b/sdk/flutter/analysis_options.yaml @@ -79,6 +79,7 @@ analyzer: - "**/*.g.dart" - "**/*.freezed.dart" errors: + avoid_print: ignore missing_required_param: error missing_return: error todo: ignore diff --git a/sdk/flutter/example/example.dart b/sdk/flutter/example/example.dart index b73158b..5635b70 100644 --- a/sdk/flutter/example/example.dart +++ b/sdk/flutter/example/example.dart @@ -1,3 +1,5 @@ +// ignore_for_file: avoid_print + import 'dart:convert'; import 'dart:io';