From 88b09914c34f3417578044e8b14a387ca373031e Mon Sep 17 00:00:00 2001 From: Gulshan Yadav Date: Mon, 2 Feb 2026 08:00:01 +0530 Subject: [PATCH] fix: resolve synor-compute clippy warnings - Replace .clone() with dereference for Copy types - Use #[derive(Default)] with #[default] attribute instead of manual impl --- crates/synor-compute/src/lib.rs | 9 ++------- crates/synor-compute/src/market/mod.rs | 2 +- crates/synor-compute/src/scheduler/load_balancer.rs | 9 ++------- crates/synor-compute/src/task/mod.rs | 11 ++++------- 4 files changed, 9 insertions(+), 22 deletions(-) diff --git a/crates/synor-compute/src/lib.rs b/crates/synor-compute/src/lib.rs index a7e43cf..ce75f34 100644 --- a/crates/synor-compute/src/lib.rs +++ b/crates/synor-compute/src/lib.rs @@ -209,11 +209,12 @@ pub enum FunctionRuntime { } /// Job priority levels. -#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)] +#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)] pub enum JobPriority { /// Background job, can be preempted. Background = 0, /// Normal priority. + #[default] Normal = 1, /// High priority, faster scheduling. High = 2, @@ -221,12 +222,6 @@ pub enum JobPriority { Critical = 3, } -impl Default for JobPriority { - fn default() -> Self { - JobPriority::Normal - } -} - /// Resource requirements for a job. #[derive(Clone, Debug, Default, Serialize, Deserialize)] pub struct ResourceRequirements { diff --git a/crates/synor-compute/src/market/mod.rs b/crates/synor-compute/src/market/mod.rs index df2e04a..bfcd489 100644 --- a/crates/synor-compute/src/market/mod.rs +++ b/crates/synor-compute/src/market/mod.rs @@ -495,7 +495,7 @@ impl OrderBook { pub fn mid_price(&self) -> Option { match (self.best_bid(), self.best_ask()) { (Some(bid), Some(ask)) => Some((bid + ask) / 2.0), - _ => self.last_price.read().clone(), + _ => *self.last_price.read(), } } diff --git a/crates/synor-compute/src/scheduler/load_balancer.rs b/crates/synor-compute/src/scheduler/load_balancer.rs index 296922a..935a76e 100644 --- a/crates/synor-compute/src/scheduler/load_balancer.rs +++ b/crates/synor-compute/src/scheduler/load_balancer.rs @@ -17,13 +17,14 @@ use std::sync::Arc; use std::time::{Duration, Instant}; /// Balancing strategy for the load balancer. -#[derive(Clone, Copy, Debug, PartialEq, Eq)] +#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)] pub enum BalancingStrategy { /// Optimize for speed (minimize execution time). Speed, /// Optimize for energy efficiency. Energy, /// Balance speed and energy. + #[default] Balanced, /// Optimize for cost (spot pricing). Cost, @@ -31,12 +32,6 @@ pub enum BalancingStrategy { Latency, } -impl Default for BalancingStrategy { - fn default() -> Self { - BalancingStrategy::Balanced - } -} - /// Real-time processor metrics. #[derive(Clone, Debug, Default)] pub struct ProcessorMetrics { diff --git a/crates/synor-compute/src/task/mod.rs b/crates/synor-compute/src/task/mod.rs index ebecfbc..9220e55 100644 --- a/crates/synor-compute/src/task/mod.rs +++ b/crates/synor-compute/src/task/mod.rs @@ -31,11 +31,14 @@ impl std::fmt::Display for TaskId { } /// Task priority levels. -#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize)] +#[derive( + Clone, Copy, Debug, Default, PartialEq, Eq, PartialOrd, Ord, Hash, Serialize, Deserialize, +)] pub enum TaskPriority { /// Background, can be preempted. Background = 0, /// Normal priority. + #[default] Normal = 1, /// High priority. High = 2, @@ -43,12 +46,6 @@ pub enum TaskPriority { Critical = 3, } -impl Default for TaskPriority { - fn default() -> Self { - TaskPriority::Normal - } -} - /// Task execution status. #[derive(Clone, Copy, Debug, PartialEq, Eq, Serialize, Deserialize)] pub enum TaskStatus {