Gulshan Yadav
|
3e68f72743
|
fix: resolve 35 clippy warnings across Rust and Dart codebases
## Rust Fixes (35 warnings resolved)
- Remove unused imports (synor-vm, synor-bridge, tests)
- Remove unused variables and prefix intentional ones with underscore
- Use derive for Default implementations (6 structs)
- Replace manual is_multiple_of with standard method (3 occurrences)
- Fix needless borrows by using direct expressions (12 occurrences)
- Suppress false-positive variant assignment warnings with allow attributes
- Fix Default field initialization pattern in synor-crypto
- Rename MerklePath::to_string() to path() to avoid conflict with Display trait
## Flutter/Dart Fixes
- Add const constructors for immutable objects (8 instances)
- Remove unused imports (dart:convert, collection package, tensor.dart)
## Impact
- Reduced clippy warnings from 49 to 10 (79% reduction)
- Remaining 10 warnings are "too many arguments" requiring architectural refactoring
- All library code compiles successfully
- Code quality and maintainability improved
|
2026-01-26 17:08:57 +05:30 |
|
Gulshan Yadav
|
a7a4a7effc
|
test: add comprehensive test suite (1,357 tests total)
Phase 1 - Test Writing (8 parallel agents):
- synord: Added 133 unit tests for node, config, services
- synor-rpc: Expanded to 207 tests for API endpoints
- synor-bridge: Added 144 tests for transfer lifecycle
- synor-zk: Added 279 tests for circuits, proofs, state
- synor-mining: Added 147 tests for kHeavyHash, miner
- synor-types: Added 146 tests for hash, amount, address
- cross-crate: Created 75 integration tests
- byzantine: Created 40+ fault scenario tests
Key additions:
- tests/cross_crate_integration.rs (new)
- apps/synord/tests/byzantine_fault_tests.rs (new)
- crates/synor-storage/src/cf.rs (new)
- src/lib.rs for workspace integration tests
Fixes during testing:
- synor-compute: Added Default impl for GpuVariant
- synor-bridge: Fixed replay protection in process_lock_event
- synor-storage: Added cf module and database exports
All 1,357 tests pass with 0 failures.
|
2026-01-20 06:35:28 +05:30 |
|